On 10/11/21 5:22 PM, Vegard Nossum wrote: > Fix the following build/link errors by adding a dependency on > CRYPTO, CRYPTO_HASH, CRYPTO_SHA256 and CRC32: > > ld: drivers/net/usb/r8152.o: in function `rtl8152_fw_verify_checksum': > r8152.c:(.text+0x2b2a): undefined reference to `crypto_alloc_shash' > ld: r8152.c:(.text+0x2bed): undefined reference to `crypto_shash_digest' > ld: r8152.c:(.text+0x2c50): undefined reference to `crypto_destroy_tfm' > ld: drivers/net/usb/r8152.o: in function `_rtl8152_set_rx_mode': > r8152.c:(.text+0xdcb0): undefined reference to `crc32_le' > We could also add: Fixes: 9370f2d05a2a1 ("r8152: support request_firmware for RTL8153") for the crypto_*() calls and Fixes: ac718b69301c7 ("net/usb: new driver for RTL8152") for the crc32_le() call (through ether_crc()). (Sorry I forgot to add this the first time around.) Vegard