On Fri, Oct 01, 2021 at 11:10:19AM +0000, Minas Harutyunyan wrote: > On 9/15/2021 11:54 AM, Fabrice Gasnier wrote: > > Currently the dwc2 doesn't fill in the 'otg_caps' of usb_gadget structure. > > When registering a gadget device (e.g. via configfs), the > > usb_otg_descriptor_init() checks the 'otg_caps' and 'otg_rev'. It defaults > > to HNP and SRP bmAttributes if unspecified. There may be a mismatch with > > what's being set in dwc2 params structure. This result in the descriptors > > to be miss-configured in this case. > > > > So add an option to setup 'otg_caps' and 'otg_rev' in the params. It's > > then provided to the gadget struct. These parameters can then be tuned > > for each platform. In case it's not set, it will default to current > > behavior. > > Also add option to setup these from the device tree by calling > > of_usb_update_otg_caps(). This provides support for standard properties > > such as "otg-rev", "hnp-disable" and "srp-disable" (see usb-drd.yaml). > > > > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx> > Acked-by: Minas Harutyunyan <Minas.Harutyunyan@xxxxxxxxxxxx> > Looks like this commit breaks the build on some configurations: https://lore.kernel.org/r/000000000000b01f1505cda8e03c@xxxxxxxxxx So I'll go drop this and the 2/3 patch from my tree. Please fix up and resend. thanks, greg k-h
