Re: [PATCH 02/13] usb: core: config: fix block comment styles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Robert:

Replying to this message would be easier if you had included an 
actual recipient list in the mail header.

On Tue, Oct 05, 2021 at 01:31:37PM +0100, Robert Greener wrote:
> Fix the following checkpatch warning at lines 45, 467, 547, 646, 696,
> 782, 897:
> 
> WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
> 
> Signed-off-by: Robert Greener <rob@xxxxxxxxxxxxxx>
> ---
>  drivers/usb/core/config.c | 21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
> index 52b0edee5b55..52aab1462787 100644
> --- a/drivers/usb/core/config.c
> +++ b/drivers/usb/core/config.c
> @@ -42,7 +42,8 @@ static int find_next_descriptor(unsigned char *buffer, int size,
>  	}
>  
>  	/* Store the number of descriptors skipped and return the
> -	 * number of bytes skipped */
> +	 * number of bytes skipped
> +	 */

In fact, the style we use in the USB subsystem is like this:

	/*
	 * Store the number of descriptors skipped and return the
	 * number of bytes skipped
	 */

with both the opening "/*" and closing "*/" on separate lines.  As 
long as you're changing the comments, you might as well update them 
to the style we use everywhere else.

Alan Stern



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux