On Tue, Sep 07, 2021 at 09:09:36AM +0800, Linyu Yuan wrote: > add gadget_info pointer in struct config_usb_cfg > to allow common gadget info trace from configfs layer. Again, I do not understand this description, can you please try to reword it? > > Signed-off-by: Linyu Yuan <quic_linyyuan@xxxxxxxxxxx> > --- > v2: no change > v3: change struct inside configfs.c > v4: no change > v5: no change > > drivers/usb/gadget/configfs.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c > index 5b2e6f9..cea12c3 100644 > --- a/drivers/usb/gadget/configfs.c > +++ b/drivers/usb/gadget/configfs.c > @@ -70,6 +70,7 @@ struct config_usb_cfg { > struct usb_configuration c; > struct list_head func_list; > struct usb_gadget_strings *gstrings[MAX_USB_STRING_LANGS + 1]; > + struct gadget_info *gi; You add a pointer, where are you removing it? thanks, greg k-h