On Mon, Oct 04, 2021 at 10:35:57PM +0200, Ferry Toth wrote:
Hi, Op 04-10-2021 om 16:18 schreef Andy Shevchenko:The commit c6e23b89a95d ("usb: dwc3: gadget: set gadgets parent to the right controller") changed the device for the UDC and broke the user space scripts that instantiate the USB gadget(s) via ConfigFS.I confirm this regression on Intel Edison since at least 5.15-rc2 while in 5.14.0 it was working fine.This patch resolves the issue as tested on 5.15-rc4. Tested-by: Ferry Toth<fntoth@xxxxxxxxx>
NACK! Why should we resolv an issue by reverting it to solve not working userspace. We already have this patch as a solution for solving a deeper Problem, regarding the allocator addressing the right device.
Revert it for now until the better solution will be proposed.
So, I think fixing the userspace would be the right fix, not changing the kernel. Otherwise we should find a proper solution.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 8e66a70adae6..13664609ed3c 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -4253,7 +4253,7 @@ int dwc3_gadget_init(struct dwc3 *dwc) } - usb_initialize_gadget(dwc->sysdev, dwc->gadget, dwc_gadget_release); + usb_initialize_gadget(dwc->dev, dwc->gadget, dwc_gadget_release); dev = &dwc->gadget->dev; dev->platform_data = dwc; dwc->gadget->ops = &dwc3_gadget_ops;
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
