Hi Michael, Thank you for the patch. On Thu, Sep 30, 2021 at 12:27:16PM +0200, Michael Grzeschik wrote: > Since the uvc video device will be created on demand, we have to ensure > that the struct is always unprepared. Otherwise the previous settings > will colide with the new perparation. > > Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx> > --- > drivers/usb/gadget/function/f_uvc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/function/f_uvc.c b/drivers/usb/gadget/function/f_uvc.c > index 1e93ab5c0c88d..b3279ba357331 100644 > --- a/drivers/usb/gadget/function/f_uvc.c > +++ b/drivers/usb/gadget/function/f_uvc.c > @@ -417,6 +417,7 @@ uvc_register_video(struct uvc_device *uvc) > int ret; > > /* TODO reference counting. */ > + memset(&uvc->vdev, 0, sizeof(struct video_device)); memset(&uvc->vdev, 0, sizeof(uvc->video)); With this and the commit message changes pointed out by Paul, Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > uvc->vdev.v4l2_dev = &uvc->v4l2_dev; > uvc->vdev.v4l2_dev->dev = &cdev->gadget->dev; > uvc->vdev.fops = &uvc_v4l2_fops; -- Regards, Laurent Pinchart
