Hi Greg,
On Tue, Sep 21, 2021 at 04:34:42PM +0200, Salvatore Bonaccorso wrote:
> From: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
>
> This reverts commit cb9c1cfc86926d0e86d19c8e34f6c23458cd3478 for
> USB_LED_TRIG. This config symbol has bool type and enables extra code
> in usb_common itself, not a separate driver. Enabling it should not
> force usb_common to be built-in!
>
> Fixes: cb9c1cfc8692 ("usb: Kconfig: using select for USB_COMMON dependency")
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> Signed-off-by: Salvatore Bonaccorso <carnil@xxxxxxxxxx>
> ---
> drivers/usb/common/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/common/Kconfig b/drivers/usb/common/Kconfig
> index 5e8a04e3dd3c..b856622431a7 100644
> --- a/drivers/usb/common/Kconfig
> +++ b/drivers/usb/common/Kconfig
> @@ -6,8 +6,7 @@ config USB_COMMON
>
> config USB_LED_TRIG
> bool "USB LED Triggers"
> - depends on LEDS_CLASS && LEDS_TRIGGERS
> - select USB_COMMON
> + depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS
> help
> This option adds LED triggers for USB host and/or gadget activity.
Sorry for bothering you again. Is this patch now ok, or do you need me
to change something else? Or do I miss something?
Regards,
Salvatore
