On 27.9.2021 21.30, Bjørn Mork wrote: > Bjørn Mork <bjorn@xxxxxxx> writes: > >> From: Jonathan Bell <jonathan@xxxxxxxxxxxxxxx> >> >> Seen on a VLI VL805 PCIe to USB controller. For non-stream endpoints >> at least, if the xHC halts on a particular TRB due to an error then >> the DCS field in the Out Endpoint Context maintained by the hardware >> is not updated with the current cycle state. >> >> Using the quirk XHCI_EP_CTX_BROKEN_DCS and instead fetch the DCS bit >> from the TRB that the xHC stopped on. >> >> [ bjorn: rebased to v5.14-rc2 ] >> Cc: stable@xxxxxxxxxxxxxxx >> Link: https://github.com/raspberrypi/linux/issues/3060 >> Signed-off-by: Jonathan Bell <jonathan@xxxxxxxxxxxxxxx> >> Signed-off-by: Bjørn Mork <bjorn@xxxxxxx> >> --- >> [ resending this as I haven't seen any ack/nak and wonder if it might >> have gotten lost in a large pile of vacation backlog ] > > ping? > Sorry about the delay, looks good to me. I'll let it go through some testing, then add it. As this goes to stable it makes sense to add it as is, but this again shows I really need to write a xhci_dma_to_trb(ring, dma) helper Thanks -Mathias
