Hi, Felipe Balbi <balbi@xxxxxxxxxx> writes: > Zhiwei Yang <yangzhiwei@xxxxxxxxxxxxx> writes: > >> Remove the debug info which should be instead with ftrace > > why? > >> Signed-off-by: Zhiwei Yang <yangzhiwei@xxxxxxxxxxxxx> >> --- >> drivers/usb/phy/phy-tahvo.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c >> index 5dc600fadc5f..468151496d23 100644 >> --- a/drivers/usb/phy/phy-tahvo.c >> +++ b/drivers/usb/phy/phy-tahvo.c >> @@ -194,8 +194,6 @@ static int tahvo_usb_set_host(struct usb_otg *otg, struct usb_bus *host) >> struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb, >> phy); >> >> - dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, host); >> - >> mutex_lock(&tu->serialize); >> >> if (host == NULL) { >> @@ -224,8 +222,6 @@ static int tahvo_usb_set_peripheral(struct usb_otg *otg, >> struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb, >> phy); >> >> - dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, gadget); > > is this causing any problems? What sort of problems? Why should we take > this patch? nevermind, I saw that your original patch was simply replacing %p with %pK but Greg asked you to just remove the lines. Thank you. Acked-by: Felipe Balbi <balbi@xxxxxxxxxx> -- balbi