On Tue, Sep 21, 2021 at 01:41:40PM +0200, Uwe Brandt wrote: > Hi Johan, > > included is a patch to make the GW Instek GDM-834x Multimeter accessible > via ttyUSBx > https://www.gwinstek.com/en-global/products/detail/GDM-8342_GDM-8341 > > lsusb output: > Bus 001 Device 002: ID 2184:0030 GW Instek GDM834X VCP PORT > > dmesg output: > [ 1102.650572] usb 1-2: cp210x converter now attached to ttyUSB0 > > patch: > diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c > index f5143eedbc..38f2b6be24 100644 > --- a/drivers/usb/serial/cp210x.c > +++ b/drivers/usb/serial/cp210x.c > @@ -228,6 +228,7 @@ static const struct usb_device_id id_table[] = { > { USB_DEVICE(0x1FB9, 0x0602) }, /* Lake Shore Model 648 Magnet Power > Supply */ > { USB_DEVICE(0x1FB9, 0x0700) }, /* Lake Shore Model 737 VSM > Controller */ > { USB_DEVICE(0x1FB9, 0x0701) }, /* Lake Shore Model 776 Hall Matrix > */ > + { USB_DEVICE(0x2184, 0x0030) }, /* GW Instek GDM-834x Digital > Multimeter */ > { USB_DEVICE(0x2626, 0xEA60) }, /* Aruba Networks 7xxx USB Serial > Console */ > { USB_DEVICE(0x3195, 0xF190) }, /* Link Instruments MSO-19 */ > { USB_DEVICE(0x3195, 0xF280) }, /* Link Instruments MSO-28 */ Thanks for the patch. Patch Subject and content looks good, but the formatting needs a little work. First, anything you put in the body goes in the commit message so greetings, etc. should go below a --- line before the diff. Second, the diff appears to be whitespace damaged (tabs replaced by spaces), possibly by your mail client. Try sending the patch to yourself first and make sure you can apply it with git-am. Also have a look at git-format-patch and git-send-email. Third, you need to sign-off on your patches. More details can be found here: Documentation/process/submitting-patches.rst Here's an example of what a patch adding a device-id could look like: https://lore.kernel.org/all/20210803194711.3036-1-dnlplm@xxxxxxxxx/ Care to send a v2? Johan
