> -----Original Message----- > From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb- > owner@xxxxxxxxxxxxxxx] On Behalf Of Woodruff, Richard > Sent: Tuesday, May 19, 2009 12:53 AM > To: Niilo Minkkinen; linux-usb@xxxxxxxxxxxxxxx > Cc: linux-omap@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx > Subject: RE: [PATCH] usb: disable OTG AUTOIDLE only with omap3430 > > > > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > > owner@xxxxxxxxxxxxxxx] On Behalf Of Niilo Minkkinen > > Sent: Monday, May 18, 2009 9:54 AM > > > Omap3 MUSB AUTOIDLE functionality configured through OTG_SYSCONFIG > > register prevents the device from going into retention. > > This is a workaround (by Richard Woodruff/TI), as his comment : > > > A new MUSB bug which is a match to data below was identified very > > > recently (on hardware and in simulation). > > > This bug is in 3430 and not 3630. > > > As a priority test (and as new default) you should have engineers > > > disable autoidle for MUSB block. > > > This is the workaround which will show up in next errata. > > > > Signed-off-by: Niilo Minkkinen <ext-niilo.1.minkkinen@xxxxxxxxx> > > Signed-off-by: Richard Woodruff <r-woodruff2@xxxxxx> > > Yes this is needed for 34xx. Side note is this cost around 1mW of power > during active mode of MUSB. When device is not active cost is not > significant. System impact depends on duty cycle of MUSB in usecase. Richard/Niilo, This should also be applicable to 35xx (right?) and so we got to update the fix with below patch. Regards, Ajay ========== patch ========================= There is an issue with MUSB AUTOIDLE as reported by Niilo Minkkinen in below commit. 9a4b5e36ce58febdd2039dd4d129ee7edf4f5536 usb: musb: disable OTG AUTOIDLE only with omap3430 As OMAP35x is just a variant of OMAP34xx chip thus the fix is also applicable for OMAP35x so updating it for OMAP35x. Signed-off-by: Ajay Kumar Gupta <ajay.gupta@xxxxxx> --- drivers/usb/musb/omap2430.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 453796c..ab8336d 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c @@ -233,7 +233,7 @@ int __init musb_platform_init(struct musb *musb) * MUSB AUTOIDLE don't work in 3430. * Workaround by Richard Woodruff/TI */ - if (!cpu_is_omap3430()) + if (!cpu_is_omap3430() && !cpu_is_omap35xx()) l |= AUTOIDLE; /* enable auto idle */ omap_writel(l, OTG_SYSCONFIG); -- 1.6.2.4 ============================================== > > Regards, > Richard W. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
