My mistake that I did not read through his comments at the end of his response. Thanks for pointing it out. -----Original Message----- From: Sergei Shtylyov [mailto:sshtylyov@xxxxxxxxxxxxx] Sent: Wednesday, August 26, 2009 3:26 PM To: Subbrathnam, Swaminathan Cc: linux-usb@xxxxxxxxxxxxxxx; davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH] MUSB: Add support for DM646x USB. Hello. Swaminathan S wrote: > DM646x USB controller is based on Mentor USB Controller (MUSB). This patch > adds support for DM646x USB controller to the MUSB driver. DM646x USB controller > doest not support OTG and hence the roles(Host/Device) need to be specified > as part of Kernel compile and the same needs to be set up when DM646x boots up. > The VBUS is controlled through a CPLD on the DM646x EVM. This patch implements > the VBUS control accordingly. > > Signed-off-by: Swaminathan S <swami.iyer@xxxxxx> Again, Kevin has already told you to rework the way VBUS is handled to avoid using machine_is_*()... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html