Re: [PATCH 3/5] usb: gadget: configfs: avoid list move operation of usb_function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Linyu,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on peter.chen-usb/for-usb-next next-20210902]
[cannot apply to balbi-usb/testing/next v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Linyu-Yuan/usb-gadget-configfs-add-some-trace-event/20210902-211519
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: hexagon-randconfig-r045-20210901 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c9948e9254fbb6ea00f66c7b4542311d21e060be)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/855bbfeebfb8ad0859f690047753221b635d391a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Linyu-Yuan/usb-gadget-configfs-add-some-trace-event/20210902-211519
        git checkout 855bbfeebfb8ad0859f690047753221b635d391a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/usb/gadget/configfs.c:1203:26: warning: variable 'cfg' set but not used [-Wunused-but-set-variable]
                   struct config_usb_cfg *cfg;
                                          ^
   1 warning generated.


vim +/cfg +1203 drivers/usb/gadget/configfs.c

88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1190  
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1191  int composite_dev_prepare(struct usb_composite_driver *composite,
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1192  		struct usb_composite_dev *dev);
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1193  
da4243145fb197 Andrzej Pietrasiewicz      2014-05-08  1194  int composite_os_desc_req_prepare(struct usb_composite_dev *cdev,
da4243145fb197 Andrzej Pietrasiewicz      2014-05-08  1195  				  struct usb_ep *ep0);
da4243145fb197 Andrzej Pietrasiewicz      2014-05-08  1196  
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1197  static void purge_configs_funcs(struct gadget_info *gi)
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1198  {
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1199  	struct usb_configuration	*c;
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1200  
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1201  	list_for_each_entry(c, &gi->cdev.configs, list) {
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1202  		struct usb_function *f, *tmp;
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23 @1203  		struct config_usb_cfg *cfg;
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1204  
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1205  		cfg = container_of(c, struct config_usb_cfg, c);
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1206  
6cd0fe91387917 Chandana Kishori Chiluveru 2020-12-29  1207  		list_for_each_entry_safe_reverse(f, tmp, &c->functions, list) {
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1208  
855bbfeebfb8ad Linyu Yuan                 2021-09-02  1209  			list_del(&f->list);
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1210  			if (f->unbind) {
da7b895d518cc1 Romain Izard               2016-08-29  1211  				dev_dbg(&gi->cdev.gadget->dev,
a08f5dbf877a45 Romain Izard               2016-07-26  1212  					"unbind function '%s'/%p\n",
a08f5dbf877a45 Romain Izard               2016-07-26  1213  					f->name, f);
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1214  				f->unbind(c, f);
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1215  			}
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1216  		}
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1217  		c->next_interface_id = 0;
903124fe1aa284 Krzysztof Opasiak          2015-03-20  1218  		memset(c->interface, 0, sizeof(c->interface));
554eead5436401 John Youn                  2016-02-05  1219  		c->superspeed_plus = 0;
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1220  		c->superspeed = 0;
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1221  		c->highspeed = 0;
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1222  		c->fullspeed = 0;
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1223  	}
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1224  }
88af8bbe4ef781 Sebastian Andrzej Siewior  2012-12-23  1225  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux