Hi Dietmar, On Fri Aug 27, 2021 at 12:15 PM WEST, Dietmar Eggemann wrote: > - deggeman@xxxxxx > + dietmar.eggemann@xxxxxxx > > On 27/08/2021 10:21, Rui Miguel Silva wrote: > > Hi, > > Dietmar complained that the latest changes to this driver > > broke booting his Arm TC2 board [0]. I did not have one of > > that boards but Dietmar provided out of band help trying to > > debug the issue, many thanks for that. > > > > Meanwhile, yesterday I could get access (remotely) to one of > > TC2 board and manage to fix the issues that were breaking > > this to work on that system. > > > > This is rebased on top of the latest (this evening) > > usb-testing/(this morning) usb-next. If, and I am sure it is > > too late to include in to 5.14, it should go to the first > > 5.14.y stable with this tag: > > > > Fixes: 1da9e1c06873 ("usb: isp1760: move to regmap for register access") > > > > Thanks again Dietmar for reporting and your help. > > > > Cheers, > > Rui > > > > [0]: https://lore.kernel.org/linux-usb/11ed5458-4b88-ad72-4497-89ff9346a40b@xxxxxx/ > > > > Rui Miguel Silva (5): > > usb: isp1760: fix memory pool initialization > > usb: isp1760: fix qtd fill length > > usb: isp1760: write to status and address register > > usb: isp1760: use the right irq status bit > > usb: isp1760: otg control register access > > > > drivers/usb/isp1760/isp1760-core.c | 50 ++++++++++++++++-------------- > > drivers/usb/isp1760/isp1760-hcd.c | 33 ++++++++++---------- > > drivers/usb/isp1760/isp1760-regs.h | 16 ++++++++++ > > drivers/usb/isp1760/isp1760-udc.c | 12 +++---- > > 4 files changed, 65 insertions(+), 46 deletions(-) > > Works fine on my TC2 too. Thanks! > > Tested-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx> Great, ... > > Maybe you can change as well to: > > Reported-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx> > > I used the wrong email address last week. Ok, I will spin a V2 with the test tag and with the email changed. Thanks for your time. Cheers, Rui