On Wed 25 Aug 2021 at 19:59, Pavel Hofman <pavel.hofman@xxxxxxxxxxx> wrote: > Dne 25. 08. 21 v 15:25 Jerome Brunet napsal(a): >> On Mon 12 Jul 2021 at 14:55, Pavel Hofman <pavel.hofman@xxxxxxxxxxx> >> wrote: >> >>> From: Ruslan Bilovol <ruslan.bilovol@xxxxxxxxx> >>> >>> USB Audio Class 1/2 have ability to change device's >>> volume and mute by USB Host through class-specific control >>> requests. Device also can notify Host about volume/mute >>> change on its side through optional interrupt endpoint. >>> >>> This patch adds Volume and Mute ALSA controls which can be >>> used by user to send and receive notifications to/from >>> the USB Host about Volume and Mute change. >>> >>> These params come from f_uac* so volume and mute controls >>> will be created only if the function support and enable >>> each explicitly >>> >>> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@xxxxxxxxx> >>> Signed-off-by: Pavel Hofman <pavel.hofman@xxxxxxxxxxx> >> Hi Greg, >> This change made it to usb-testing and usb-next but there are several >> indentation errors in it. By itself, without the rest of the series, it >> does not make much sense. It adds a couple of alsa controls but those >> actually do nothing without the uac1 and uac2 part of the series. >> Maybe it would be better to drop this change until the rest of series is >> ready (if this is still possible) ? >> > > The indentation errors were fixed by commit > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=1bc220835526ae076eecfb7ed513f80f22cf840d Could you check again ? I believe you missed some in u_audio.c (at least). > which is in usb-next now too. If possible this commit should be dropped too. > > Thanks, > > Pavel.
