On Tue, Aug 24, 2021 at 03:55:41PM +0200, Johan Hovold wrote: > On Sat, Aug 21, 2021 at 12:33:06AM +0530, Utkarsh Verma wrote: > > This fixed the below checkpatch issue: > > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. > > Consider using octal permissions '0644'. > > Please do not run checkpatch.pl on code that's already in the tree. Use > it for your own patches before submitting them and always use your own > judgement when considering its suggestions. > Okay, I will not run checkpatch on the code that's already in the tree. > This code does not need to be changed. > But using the octal permission bits makes the code more readable. So I made the change. But if you don't want such changes, I will refrain from doing it in the future. Anyway thanks for the review. Regards, Utkarsh Verma
