On Sat, 2021-08-21 at 00:39 +0200, Niklas Lantau wrote: > Fixed coding style issues that generated 1 error and 1 warning. While this hardly needs changing: > diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c [] > @@ -295,7 +295,7 @@ void fill_inquiry_response(struct us_data *us, unsigned char *data, > } > EXPORT_SYMBOL_GPL(fill_inquiry_response); > > > -static int usb_stor_control_thread(void * __us) > +static int usb_stor_control_thread(void *__us) > { > struct us_data *us = (struct us_data *)__us; > struct Scsi_Host *host = us_to_host(us); I'd write this renaming __us to the much more typical data and remove the useless cast of a void *. --- drivers/usb/storage/usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c index 90aa9c12ffac5..e78e20fb1afa5 100644 --- a/drivers/usb/storage/usb.c +++ b/drivers/usb/storage/usb.c @@ -295,9 +295,9 @@ void fill_inquiry_response(struct us_data *us, unsigned char *data, } EXPORT_SYMBOL_GPL(fill_inquiry_response); -static int usb_stor_control_thread(void * __us) +static int usb_stor_control_thread(void *data) { - struct us_data *us = (struct us_data *)__us; + struct us_data *us = data; struct Scsi_Host *host = us_to_host(us); struct scsi_cmnd *srb;