At 2021-08-16 19:17:11, "Greg KH" <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: >On Mon, Aug 16, 2021 at 05:25:20PM +0800, Slark Xiao wrote: >> At 2021-08-16 17:20:59, "Greg KH" <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: >> >On Mon, Aug 16, 2021 at 05:17:00PM +0800, Slark Xiao wrote: >> >> So should I use USB_DEVICE_INTERFACE_NUMBER(QUALCOMM_VENDOR_ID, 0x901d, 0x00) to bind Diag port only? >> > >> >Why is this device using the QUALCOMM vendor id anyway? Is this allowed >> >by Qualcomm? >> > >> >thanks, >> > >> >greg k-h >> >> Hi Greg, >> Our product are designed based on Qualcomm SDX55 platform. So it still support Qualcomm vendor ID. >> I think there is no infringement about this ID combo. > >Do you have permission from Qualcomm to use their vendor id? I know >some vendors get very upset about this... > >Why not use your own vendor id? > >thanks, > >greg k-h Hi Greg, As Qualcomm mainly provide service to their customer, like Samsung, Apple, Huawei, Quectel, Foxconn, Sierra and so on, so I believe all available VID/PIDs are allowed to use. I also checked who is using Qualcomm's VID in the whole kernel, and I found only some old platform (Gobi 1K,2K,3K which don't do any update for almost more than 10 years) in qcserial.c and ZTE, SIMcom, Quectel in option.c are using this VID. Seems Qualcomm won't do this update in the kernel side by themselves(let's say some new PID, 901x,902x,903x,904x,905x...90Fx, and 91xx). About the question why not use our own VID, because this PCIE+USB mode is for debug purpose. We need to keep a common debug settings for both Linux and Windows platform, also for all our customers like Lenovo, Dell, HP, Telit. Hope you can understand that. Thanks Slark