On 09/08/2021 22:35, Sergey Shtylyov wrote: > The driver neglects to check the result of platform_get_irq()'s call and > blithely passes the negative error codes to request_irq() (which takes > *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original > error code. Stop calling request_irq() with the invalid IRQ #s. > > Fixes: 188db4435ac6 ("usb: gadget: s3c: use platform resources") > Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx> > > --- > drivers/usb/gadget/udc/s3c2410_udc.c | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> Best regards, Krzysztof