Hi Sergey, On Sun, Aug 8, 2021 at 10:37 PM Sergey Shtylyov <s.shtylyov@xxxxxx> wrote: > > The driver neglects to check the result of platform_get_irq()'s call and > blithely passes the negative error codes to devm_request_threaded_irq() > (which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding > an original error code. Stop calling devm_request_threaded_irq() with the > invalid IRQ #s. > > Fixes: f90db10779ad ("usb: dwc3: meson-g12a: Add support for IRQ based OTG switching") > Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx> Thanks for spotting and fixing this issue! Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>