Re: [Patch] unusual_devs.h: drop some unneeded floppy entries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pete Zaitcev wrote:
> We set pdt_1f_for_no_lun for UFI devices, so most floppy entiries should
> be unnecessary. This patch removes three entries which I'm certain are.
>  - For Mitsumi I have a customer with RHEL 5 (bz#514296)
>  - For SMSC I accessed Novell's Bugzilla and verified the entry
>  - For Y-E I tested the patch with the actual device
> 
> Signed-Off-By: Pete Zaitcev <zaitcev@xxxxxxxxxx>
Signed-off-by: Phil Dibowitz <phil@xxxxxxxx>

Yeah for nuking entries.

> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -66,13 +66,6 @@ UNUSUAL_DEV(  0x03eb, 0x2002, 0x0100, 0x0100,
>  		US_SC_DEVICE, US_PR_DEVICE, NULL,
>  		US_FL_IGNORE_RESIDUE),
>  
> -/* modified by Tobias Lorenz <tobias.lorenz@xxxxxxx> */
> -UNUSUAL_DEV(  0x03ee, 0x6901, 0x0000, 0x0200,
> -		"Mitsumi",
> -		"USB FDD",
> -		US_SC_DEVICE, US_PR_DEVICE, NULL,
> -		US_FL_SINGLE_LUN ),
> -
>  /* Reported by Rodolfo Quesada <rquesada@xxxxxxxx> */
>  UNUSUAL_DEV(  0x03ee, 0x6906, 0x0003, 0x0003,
>  		"VIA Technologies Inc.",
> @@ -233,13 +226,6 @@ UNUSUAL_DEV(  0x0421, 0x0495, 0x0370, 0x0370,
>  		US_SC_DEVICE, US_PR_DEVICE, NULL,
>  		US_FL_MAX_SECTORS_64 ),
>  
> -/* Reported by Olaf Hering <olh@xxxxxxx> from novell bug #105878 */
> -UNUSUAL_DEV(  0x0424, 0x0fdc, 0x0210, 0x0210,
> -		"SMSC",
> -		"FDC GOLD-2.30",
> -		US_SC_DEVICE, US_PR_DEVICE, NULL,
> -		US_FL_SINGLE_LUN ),
> -
>  #ifdef NO_SDDR09
>  UNUSUAL_DEV(  0x0436, 0x0005, 0x0100, 0x0100,
>  		"Microtech",
> @@ -664,19 +650,13 @@ UNUSUAL_DEV(  0x055d, 0x2020, 0x0000, 0x0210,
>  		US_SC_DEVICE, US_PR_DEVICE, NULL,
>  		US_FL_SINGLE_LUN ),
>  
> -		
> +/* We keep this entry to force the transport; firmware 3.00 and later is ok. */
>  UNUSUAL_DEV(  0x057b, 0x0000, 0x0000, 0x0299,
>  		"Y-E Data",
>  		"Flashbuster-U",
>  		US_SC_DEVICE,  US_PR_CB, NULL,
>  		US_FL_SINGLE_LUN),
>  
> -UNUSUAL_DEV(  0x057b, 0x0000, 0x0300, 0x9999,
> -		"Y-E Data",
> -		"Flashbuster-U",
> -		US_SC_DEVICE,  US_PR_DEVICE, NULL,
> -		US_FL_SINGLE_LUN),
> -
>  /* Reported by Johann Cardon <johann.cardon@xxxxxxx>
>   * This entry is needed only because the device reports
>   * bInterfaceClass = 0xff (vendor-specific)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


-- 
Phil Dibowitz                             phil@xxxxxxxx
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Never write it in C if you can do it in 'awk';
 Never do it in 'awk' if 'sed' can handle it;
 Never use 'sed' when 'tr' can do the job;
 Never invoke 'tr' when 'cat' is sufficient;
 Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming


Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux