On Fri, Jul 23, 2021 at 06:22:03PM +0300, Maxim Devaev wrote: > > Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> writes: > > Who is the original author here? Please put their name as the "From:" > > line in the changelog so we can give proper credit if it was not you. > > Phil Elwell. Fixed. > > > Test for !req and then abort, and then continue on. No need for moving > > the copy_from_user line in, right? Should make the change smaller > > overall. > > Fixed. > > > Blank line after this please. > > Added. > > > Are the braces still needed here? > > No, you're right. > > Thanks for the review! Here the new version of the patch: > > From 72a504af8e3df3d7a44e9954b8cf03268795c07f Mon Sep 17 00:00:00 2001 > From: Phil Elwell <phil@xxxxxxxxxxxxxxx> > Date: Fri, 23 Jul 2021 11:59:49 +0300 > Subject: [PATCH] usb: gadget: f_hid: fixed NULL pointer dereference <snip> Please resend as a v2 in a format that I can apply it in (as a new email.) thanks, greg k-h
