On Wed, Jul 14, 2021 at 6:55 PM David Jeffery <djeffery@xxxxxxxxxx> wrote: > On Wed, Jul 14, 2021 at 10:27 AM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Wed, Jul 14, 2021 at 10:03:09AM -0400, David Jeffery wrote: > > > > Thanks, I have few minor comments, after addressing them feel free to add > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > > > When MSI is used by the ehci driver, it can cause interrupts to be lost which > > > > ehci -> EHCI everywhere? > > > > Are you asking for a capitalization change in the text or asking what > all is affected by the bug? I'm suggesting to capitalize the abbreviation (maybe not in all cases, but where you refer to the hardware, for the driver it's called ehci-hcd). ... > > > u32 status, masked_status, pcd_status = 0, cmd; > > > + u32 current_status; > > > > Perhaps > > > > u32 status, current_status, masked_status, pcd_status = 0; > > u32 cmd; > > > > ? > > Is this a style preference? I can change it and just did it in a way > to minimize line changes. Yes, I believe it's a preference of having something unified semantically on one line. -- With Best Regards, Andy Shevchenko
