Re: [PATCH] usb: dwc2: gadget: Fix GOUTNAK flow for Slave mode.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 12, 2021 at 02:22:09PM +0400, Minas Harutyunyan wrote:
> Because of dwc2_hsotg_ep_stop_xfr() function uses poll
> mode, first need to mask GINTSTS_GOUTNAKEFF interrupt.
> In Slave mode GINTSTS_GOUTNAKEFF interrupt will be
> aserted only after pop OUT NAK status packet from RxFIFO.
> 
> In dwc2_hsotg_ep_sethalt() function before setting
> DCTL_SGOUTNAK need to unmask GOUTNAKEFF interrupt.
> 
> Tested by USBCV CH9 and MSC tests set in Slave, BDMA and DDMA.
> All tests are passed.
> 
> Fixes: a4f827714539a ("usb: dwc2: gadget: Disable enabled HW endpoint in
> dwc2_hsotg_ep_disable")

Please do not wrap this line.

> Fixes: 6070636c4918c ("usb: dwc2: Fix Stalling a Non-Isochronous OUT EP")
> 

No need for a blank line there please.

thanks,

gre gk-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux