Re: [PATCH v5 0/2] IR driver for USB-UIRT device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 18, 2021 at 11:18:45AM +0100, Sean Young wrote:
> This is a new rc-core driver for the USB-UIRT which you can see here
> http://www.usbuirt.com/
> 
> This device is supported in lirc, via the usb serial kernel driver. This
> driver is both for rc-core, which means it can use kernel/BPF decoding
> ec. Also this implement is superior because it can:
>  - support learning mode
>  - setting transmit carrier
>  - larger transmits using streaming tx command
>  - Much better latency since it is a kernel driver

A ball-park number to back this claim up would be good here. Your driver
sets the ftdi latency timer to 50 ms which adds quite a bit of latency
for short packets (e.g. a single key press?) to begin with.

> Changes since v4:
>  - Fixed clang warning/uninitialized variable usage
>  - Some cosmetic changes
> 
> Changes since v3:
>  - Review comments from Johan Hovold

In the future, please include some details on what changed also when
addressing review feedback.

>  - Do not move the ftdi_sio.h file an copy FTDI_* definitions instead
> 
> Changes since v2:
>  - Fixed race condition is disconnect
>  - Removed superfluous kmalloc in short tx
> 
> Changes since v1:
>  - Review comments from Oliver Neukum
>  - Simplified wideband read function
> 
> Sean Young (2):
>   media: rc: new driver for USB-UIRT device
>   USB: serial: blacklist USB-UIRT when driver is selected
> 
>  drivers/media/rc/Kconfig      |  11 +
>  drivers/media/rc/Makefile     |   1 +
>  drivers/media/rc/uirt.c       | 744 ++++++++++++++++++++++++++++++++++
>  drivers/usb/serial/ftdi_sio.c |   6 +-
>  4 files changed, 760 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/media/rc/uirt.c

Johan



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux