On Tue, Aug 18, 2009 at 02:33:38PM +0530, Gadiyar, Anand wrote: > > On Fri, Aug 14, 2009 at 07:58:23AM +0200, ext Daniel Mack wrote: > > > This adds a minimal driver for NXP's ISP1504 transceivers, using the OTG > > > framework functions recently introduced. > > > > I don't really like this one that much since those registers of yours > > are defined in the ulpi-spec, right ? So this is basic the role the > > nop-xceiv was designed for. > > > > Those ulpi-only transceivers work mostly autonomously, the main reason > > you'd need to talk to them would be for manual usb charger detection and > > stuff that are out of the ulpi spec. > > > > There would be reasons you would want to talk to them. Charger detection > is not the only reason. > > > If we take this forward, so far, I see we're gonna a bunch of > > look-alike drivers. > > Different link controllers have different methods for accessing the > transceiver's registers. This series is only adding function pointers > that can be populated later depending on the controller used. I think > it is useful to have. Yes. However, if someone comes up with a more versatile, more generic API for such chips to control, I'd go and change it before the first version is taken. I'm just a little uncertain about what is needed. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html