Re: [RFC PATCH 2/7] usb: typec: ucsi: Don't stop alt mode registration on busy condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

On 07.06.2021 16:14, Heikki Krogerus wrote:

If the PPM tells it's busy, we can now simply try again.

Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
---
  drivers/usb/typec/ucsi/ucsi.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
index 366c8a468bc18..a8e0e31dcddf5 100644
--- a/drivers/usb/typec/ucsi/ucsi.c
+++ b/drivers/usb/typec/ucsi/ucsi.c
@@ -437,8 +437,11 @@ static int ucsi_register_altmodes(struct ucsi_connector *con, u8 recipient)
  		command |= UCSI_GET_ALTMODE_CONNECTOR_NUMBER(con->num);
  		command |= UCSI_GET_ALTMODE_OFFSET(i);
  		len = ucsi_send_command(con->ucsi, command, alt, sizeof(alt));

   Could insert your check here, to reduce the indentation...

-		if (len <= 0)
+		if (len <= 0) {
+			if (len == -EBUSY)
+				continue;
  			return len;
+		}
/*
  		 * This code is requesting one alt mode at a time, but some PPMs

MBR, Sergei



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux