On Tue, Jun 08, 2021 at 09:42:09AM +0300, Heikki Krogerus wrote: > On Mon, Jun 07, 2021 at 10:09:58PM +0200, Benjamin Berg wrote: > > Hi Heikki, > > > > On Mon, 2021-06-07 at 16:14 +0300, Heikki Krogerus wrote: > > > This is the RFC series I promised [1]. > > > > Cool. > > > > > I'm sorry it took this long to prepare these. I had to concentrate on > > > other task for a while. > > > > > > Let me know if you still see any problems. > > > > Hmm, I am not sure this got better. I applied the patchset on top of of > > the 5.12.9 Fedora 34 kernel. On the machine in question (X1 Carbon 8), > > I see the online state getting stuck at 1 occasionally. This can happen > > for example when quickly plugging and unplugging a USB-C charger. > > Please check does the partner device get removed. What do you have > under /sys/class/typec after that happens? Oh yes. Could you also share the trace output when that happens? cd /sys/kernel/debug/tracing echo 1 > events/ucsi/enable # now reproduce the issue cat trace > ucsi.trace thanks, -- heikki