Re: [PATCH v5] usb: pci-quirks: disable D3cold on xhci suspend for s2idle on AMD Renoir

"Limonciello, Mario" <mario.limonciello@xxxxxxx> · Wed, 2 Jun 2021 10:13:21 -0500

On 6/2/2021 10:03, Greg Kroah-Hartman wrote:
On Thu, May 27, 2021 at 10:45:34AM -0500, Mario Limonciello wrote:
The XHCI controller is required to enter D3hot rather than D3cold for AMD
s2idle on this hardware generation.

Otherwise, the 'Controller Not Ready' (CNR) bit is not being cleared by
host in resume and eventually this results in xhci resume failures during
the s2idle wakeup.

Suggested-by: Prike Liang <Prike.Liang@xxxxxxx>
Link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flinux-usb%2F1612527609-7053-1-git-send-email-Prike.Liang%40amd.com%2F&amp;data=04%7C01%7Cmario.limonciello%40amd.com%7C07d80c804533439da6ad08d925d798a8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637582430177777264%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=uV%2FMr7rXtBVzNmEBg%2FrIoXVKfLAjdQOO4rkR8DrdhBw%3D&amp;reserved=0
Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
---
  drivers/usb/host/xhci-pci.c | 7 ++++++-
  drivers/usb/host/xhci.h     | 1 +
  2 files changed, 7 insertions(+), 1 deletion(-)

Should it go to stable kernels, and if so, how far back?

thanks,

greg k-h

Sure, as far back as 5.11 makes sense to me.