On Wed, May 26, 2021 at 01:03:11PM +0300, eli.billauer@xxxxxxxxx wrote: > From: Eli Billauer <eli.billauer@xxxxxxxxx> > > The XillyUSB driver is the USB variant for the Xillybus FPGA IP core. > Even though it presents a nearly identical API on the FPGA and host, > it's almost a complete rewrite of the driver: The framework for exchanging > data on a USB bus is fundamentally different from doing the same with a > PCIe interface, which leaves very little in common between the existing > driver and the new one for XillyUSB. > > Signed-off-by: Eli Billauer <eli.billauer@xxxxxxxxx> > --- > > Notes: > Changelog: > > v5: > - Move xillyusb.c back from staging to char/xillybus/ > - Turn previously lockless FIFO into one relying on a lock > - Set driver's soft_unbind flag, so that the device is notified when the > driver is unloaded + due changes for killing URBs as required > - Some refactoring of locks for better granularity > - Avoid using pr_err and pr_warn, replace with dev_* counterparts > - Bump MODULE_VERSION to 1.1 Nit, you should just remove the MODULE_VERSION() stuff, it makes no sense once it is in the kernel tree to have them as they then mean nothing. But that can be an add-on patch, let me review these...
