On Wed, May 19, 2021 at 11:55:34AM +0300, Andy Shevchenko wrote:
> As LKP noticed the Sparse is not happy about strict type handling:
> .../typec/tcpm/wcove.c:380:50: sparse: expected unsigned short [usertype] header
> .../typec/tcpm/wcove.c:380:50: sparse: got restricted __le16 const [usertype] header
>
> Fix this by switching to use pd_header_cnt_le() instead of pd_header_cnt()
> in the affected code.
>
> Fixes: ae8a2ca8a221 ("usb: typec: Group all TCPCI/TCPM code together")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/typec/tcpm/wcove.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/wcove.c b/drivers/usb/typec/tcpm/wcove.c
> index 79ae63950050..5d125339687a 100644
> --- a/drivers/usb/typec/tcpm/wcove.c
> +++ b/drivers/usb/typec/tcpm/wcove.c
> @@ -378,7 +378,7 @@ static int wcove_pd_transmit(struct tcpc_dev *tcpc,
> const u8 *data = (void *)msg;
> int i;
>
> - for (i = 0; i < pd_header_cnt(msg->header) * 4 + 2; i++) {
> + for (i = 0; i < pd_header_cnt_le(msg->header) * 4 + 2; i++) {
> ret = regmap_write(wcove->regmap, USBC_TX_DATA + i,
> data[i]);
> if (ret)
> --
> 2.30.2
--
heikki
