On Fri, 14 Aug 2009, [iso-8859-2] Micha³ Nazarewicz wrote: > The patchset introduces a File-backed Storage Gadget (FSG) converted > to use a composite framework. The first patch adds File-backed > Storage Function (FSF) which is heavily based on the FSG. The second > patch converts FSG to use FSF and composite framework. I'm glad that someone has decided to do this work! > Moreover, FSF introduces several changes compared to FSG. First of > all, the read-only flag, removable and CD-ROM emulation is configured > per-LUN basis rather then globally for the whole function. On the contrary: FSG has always made the read-only flag per-LUN. There didn't seem to be any need to make the other two flags per-LUN, on the theory that all the LUNs in a device should have the same characteristics. Questionable, I know. Regardless, this seems unrelated to the matter of converting things over to the composite framework. Perhaps you should separate it out into a completely independent patch. ... > Now, what's yet to be done is move the kernel thread related data > to the fsf_common structure. Currently, when FSF is added to two > configurations two kernel threads are created -- only one is active at > a time but still, it's not good design. So if you added two FSF interfaces to each of two configurations, there would be four threads? Yes, that should be fixed. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
