On Tue, May 18, 2021 at 10:05:49AM -0700, Matthias Kaehlcke wrote: > Hi Alan, > > You seemed to have a generally favorable view of this driver, > but I haven't heard from you in a while :) > > On v4 expressed a series of suggestions and concerns, which > should be addressed in this version: > > https://lore.kernel.org/patchwork/patch/1313000/ > https://lore.kernel.org/patchwork/patch/1313001/ > > Rob acked the DT binding and the of_platform change. Please let me > know if the USB part needs any further changes or if you think this > series is ready to land. Those were long and complicated threads, and a lot of the material has gone out of my brain since last October. :-( Still, at the time when this was first posted I don't remember there being any big outstanding issues regarding the USB part of the implementation. It seemed to be pretty much all in order. You can add: Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> to this patch. Greg KH may have some thoughts of his own... Alan Stern