Re: [PATCH 2/4] USB OTG: Add driver for NXP's ISP1504 transceiver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 14, 2009 at 08:52:33AM +0200, Valentin Longchamp wrote:
> >On Fri, Aug 14, 2009 at 07:58:23AM +0200, Daniel Mack wrote:
> >>diff --git a/include/linux/usb/isp1504.h b/include/linux/usb/isp1504.h
> >>new file mode 100644
> >>index 0000000..2c14a18
> >>--- /dev/null
> >>+++ b/include/linux/usb/isp1504.h
> >>@@ -0,0 +1,6 @@
> >>+#ifndef __LINUX_USB_ISP1504_XCVR_H
> >>+#define __LINUX_USB_ISP1504_XCVR_H
> >>+
> >>+extern struct otg_transceiver *otg_isp1504_create(struct otg_io_access_ops *ops);
> >>+
> >>+#endif /* __LINUX_USB_ISP1504_XCVR_H */
> >
> >Ah, sorry - as Valentin pointed out, that 'extern' shouldn't be there.
> >Take the patch below instead please.
> 
> Well, you also have forgotten the #include <linux/usb/otg.h> so that
> struct otg_io_access is defined in include/linux/usb/isp1504.h
> (otherwise you get a warning).

Ah, I didn't get that detail from your previous mail.

> I'm sending the patch as a reply (if this is the only change you
> have done to this patch Daniel ?)

Yes, it is. Thanks!

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux