Hi Laurent, On Thu May 6, 2021 at 3:59 PM WEST, Laurent Pinchart wrote: > Hi Rui, > > On Thu, May 06, 2021 at 03:14:15PM +0100, Rui Miguel Silva wrote: > > On Thu May 6, 2021 at 2:45 PM WEST, Laurent Pinchart wrote: > > > On Thu, May 06, 2021 at 02:39:13PM +0100, Rui Miguel Silva wrote: > > > > On Thu May 6, 2021 at 1:24 PM WEST, Laurent Pinchart wrote: > > > > > On Tue, May 04, 2021 at 11:19:04AM +0100, Rui Miguel Silva wrote: > > > > > > Rework access to registers and memory to use regmap framework. > > > > > > No change in current feature or way of work is intended with this > > > > > > change. > > > > > > > > > > > > This will allow to reuse this driver with other IP of this family, > > > > > > for example isp1763, with little changes and effort. > > > > > > > > > > > > Signed-off-by: Rui Miguel Silva <rui.silva@xxxxxxxxxx> > > > > > > --- <big snip> > > > > > > > > > > > > spin_unlock_irqrestore(&udc->lock, flags); > > > > > > } > > > > > > @@ -1091,19 +1158,30 @@ static void isp1760_udc_init_hw(struct isp1760_udc *udc) > > > > > > * ACK tokens only (and NYET for the out pipe). The default > > > > > > * configuration also generates an interrupt on the first NACK token. > > > > > > */ > > > > > > - isp1760_udc_write(udc, DC_INTCONF, DC_CDBGMOD_ACK | DC_DDBGMODIN_ACK | > > > > > > - DC_DDBGMODOUT_ACK_NYET); > > > > > > - > > > > > > - isp1760_udc_write(udc, DC_INTENABLE, DC_IEPRXTX(7) | DC_IEPRXTX(6) | > > > > > > - DC_IEPRXTX(5) | DC_IEPRXTX(4) | DC_IEPRXTX(3) | > > > > > > - DC_IEPRXTX(2) | DC_IEPRXTX(1) | DC_IEPRXTX(0) | > > > > > > - DC_IEP0SETUP | DC_IEVBUS | DC_IERESM | DC_IESUSP | > > > > > > - DC_IEHS_STA | DC_IEBRST); > > > > > > + isp1760_udc_set(udc, DC_CDBGMOD_ACK); > > > > > > + isp1760_udc_set(udc, DC_DDBGMODIN_ACK); > > > > > > + isp1760_udc_set(udc, DC_DDBGMODOUT_ACK); > > > > > > + > > > > > > + isp1760_udc_set(udc, DC_IEPRXTX_7); > > > > > > + isp1760_udc_set(udc, DC_IEPRXTX_6); > > > > > > + isp1760_udc_set(udc, DC_IEPRXTX_5); > > > > > > + isp1760_udc_set(udc, DC_IEPRXTX_4); > > > > > > + isp1760_udc_set(udc, DC_IEPRXTX_3); > > > > > > + isp1760_udc_set(udc, DC_IEPRXTX_2); > > > > > > + isp1760_udc_set(udc, DC_IEPRXTX_1); > > > > > > + isp1760_udc_set(udc, DC_IEPRXTX_0); > > > > > > + > > > > > > + isp1760_udc_set(udc, DC_IEP0SETUP); > > > > > > + isp1760_udc_set(udc, DC_IEVBUS); > > > > > > + isp1760_udc_set(udc, DC_IERESM); > > > > > > + isp1760_udc_set(udc, DC_IESUSP); > > > > > > + isp1760_udc_set(udc, DC_IEHS_STA); > > > > > > + isp1760_udc_set(udc, DC_IEBRST); > > This is another place I've spotted while casually looking at the patch. Ok, I will change it. Many Thanks, Rui
