Hi Guenter, On Sat, Apr 24, 2021 at 11:03:19AM +0300, Felipe Balbi wrote: > Guenter Roeck <linux@xxxxxxxxxxxx> writes: > > The parameters passed to allow_link and drop_link functions are never NULL. > > That means the result of container_of() on those parameters is also > > never NULL, even if the reference into the structure points to the first > > element of the structure. Remove the subsequent NULL checks. > > > > The changes in this patch were made automatically using the following > > Coccinelle script. > > > > @@ > > type t; > > identifier v; > > statement s; > > @@ > > > > <+... > > ( > > t v = container_of(...); > > | > > v = container_of(...); > > ) > > ... > > when != v > > - if (\( !v \| v == NULL \) ) s > > ...+> > > > > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Cc: Felipe Balbi <balbi@xxxxxxxxxx> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > --- > > After the recent discussion about a patch which tried to add a check > > against NULL after container_of(), I realized that there are a number > > of such checks in the kernel. > > > > Now the big question: Are patches like this acceptable, or do they count > > as noise ? > > Not noise in my book :-) > > Acked-by: Felipe Balbi <balbi@xxxxxxxxxx> Likewise, Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> And thank you for the patch. -- Regards, Laurent Pinchart
