On Mon, Apr 12, 2021 at 12:59:40PM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 12, 2021 at 11:47:28AM +0200, Johan Hovold wrote: > > The io_ti and ti_usb_3410_5052 drivers are drivers for devices based on > > the same TI chips and one appears to have been based on the other > > judging from the code similarities. > > All I had to work off of was a vendor-driver for the ti_usb_3410_5052 > codebase and trying to figure out what was common and what wasn't was > pretty hard at the time. Thanks for working on this cleanup now. Ah, thanks. That explains the similarities. > > This series clean up their implementations a bit by introducing > > port-command helpers and fixing up some related style inconsistencies. > > > > This is based on top of the recently posted closing-wait series. > > Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> And thanks for reviewing both of these sets. Now applied. Johan