On Thu, Apr 08, 2021 at 10:38:15AM +0200, Greg Kroah-Hartman wrote: > On Thu, Apr 08, 2021 at 11:28:09AM +0300, Heikki Krogerus wrote: > > On Wed, Apr 07, 2021 at 05:15:40PM +0800, Zhen Lei wrote: > > > Fixes the following W=1 kernel build warning: > > > > > > drivers/usb/typec/tcpm/tcpm.c:2107:39: warning: ‘tcpm_altmode_ops’ defined but not used [-Wunused-const-variable=] > > > > > > The reference to the variable 'tcpm_altmode_ops' is deleted by the > > > commit a079973f462a ("usb: typec: tcpm: Remove tcpc_config configuration > > > mechanism"). > > > > > > By the way, the static functions referenced only by the variable > > > 'tcpm_altmode_ops' are deleted accordingly. > > > > > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > > > Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx> > > > > Oh, I thought this was already fixed. Should this go into the stable > > trees as well? > > We do not build kernels by default with "W=1" yet, so it's not needed > in stable kernels. Okay, got it. thanks, -- heikki