On Thu, Apr 01, 2021 at 06:17:15PM +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/usb/host/xhci.c:1346:15: warning: variable ‘len’ set but not
> used [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
> drivers/usb/host/xhci.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 1975016..0ead09c 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -1343,7 +1343,6 @@ static bool xhci_urb_temp_buffer_required(struct usb_hcd *hcd,
>
> static void xhci_unmap_temp_buf(struct usb_hcd *hcd, struct urb *urb)
> {
> - unsigned int len;
> unsigned int buf_len;
> enum dma_data_direction dir;
>
> @@ -1359,10 +1358,9 @@ static void xhci_unmap_temp_buf(struct usb_hcd *hcd, struct urb *urb)
> dir);
>
> if (usb_urb_dir_in(urb))
> - len = sg_pcopy_from_buffer(urb->sg, urb->num_sgs,
> - urb->transfer_buffer,
> - buf_len,
> - 0);
> + sg_pcopy_from_buffer(urb->sg, urb->num_sgs,
> + urb->transfer_buffer,
> + buf_len, 0);
>
> urb->transfer_flags &= ~URB_DMA_MAP_SINGLE;
> kfree(urb->transfer_buffer);
> --
> 1.8.3.1
>
Why resubmit this same change when I rejected it in the past?
{sigh}
greg k-h
