On Thu, Aug 06, 2009 at 03:13:59PM -0400, Dave Jones wrote: > On Thu, Aug 06, 2009 at 11:33:26AM -0700, Greg Kroah-Hartman wrote: > > > > I agree. In fact, I'd go further, and say that the bulk of what we have > > > in pci_ids.h is also pointlessly shared. Only a tiny fraction of the device > > > entries in that file are used by multiple files in the kernel. > > > > I agree with that as well, which is why when I was PCI maintainer, I > > didn't allow any new additions to the pci_ids.h file, unless it was > > going to be an id that was shared by different drivers. That cut the > > new additions down to about none :) > > Perhaps documenting this is a good idea to prevent things being moved there, > as it still seems to be happening judging from the git log. > > Signed-off-by: Dave Jones <davej@xxxxxxxxxx> > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index 73b46b6..f9156fd 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2,6 +2,9 @@ > * PCI Class, Vendor and Device IDs > * > * Please keep sorted. > + * > + * Do not add new entries to this file unless the definitions > + * are shared between multiple drivers. > */ > > /* Device classes and subclasses */ > ACK -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
