On Wed, Mar 24, 2021 at 04:44:31PM +0000, Artur Petrosyan wrote: > Hi Greg, > > On 3/23/2021 15:24, Greg Kroah-Hartman wrote: > > On Thu, Mar 18, 2021 at 10:12:46AM +0400, Artur Petrosyan wrote: > >> - Added a default param "power_saving" to enable or > >> disable hibernation or partial power down features. > >> > >> - Printed hibernation param in hw_params_show and > >> power_saving param in params_show. > > > > This says what you are doing, but not _why_ you are doing this. Why is > > this needed at all? > > > > Please read the documentation for how to write a good changelog text for > > when you resubmit this series. > > Thank you for your reply. I have corrected changelog of the patch > according the documentation. Will submit in series. > > > > > Also note that the emails were not "threaded", was that on purpose? > Yes, the patches that were included in the "usb: dwc2: Fix and improve > power saving modes" which was submitted earlier were too large and > needed to be split up into smaller patches. > We had a discussion about that with Felipe Balbi earlier. Here is the > link to the discussion thread > (https://marc.info/?l=linux-usb&m=160379651904064&w=2) > So I did the split and obviously the cover letter and the subject were > changed therefor I have submitted the updates with this thread and > mentioned in the cover letter that these are continuation of the > previous patch set that was too large. No, I mean you are not "threading" your emails so that they show up as one after another all in the same email "thread". Please use git-send-email to do this, or some other tool. thanks, greg k-h
