Sorry, I will check all my patch later before I send to maintainer and I will stop this patch series. -----邮件原件----- 发件人: Greg Kroah-Hartman [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] 发送时间: 2021年3月26日 14:38 收件人: zhengyongjun <zhengyongjun3@xxxxxxxxxx> 抄送: Andrey Konovalov <andreyknvl@xxxxxxxxxx>; Dmitry Vyukov <dvyukov@xxxxxxxxxx>; Masahiro Yamada <masahiroy@xxxxxxxxxx>; Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>; Ahmed S. Darwish <a.darwish@xxxxxxxxxxxxx>; Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>; Sasha Levin <sashal@xxxxxxxxxx>; Allen Pais <allen.lkml@xxxxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx; pmail_hulkci <hulkci@xxxxxxxxxx> 主题: Re: [PATCH -next] usb: remove unused including <linux/version.h> On Fri, Mar 26, 2021 at 02:13:26PM +0800, Zheng Yongjun wrote: > Remove including <linux/version.h> that don't need it. > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx> > --- > drivers/usb/core/hcd.c | 1 - > 1 file changed, 1 deletion(-) > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index > 3f0381344221..53bc93d6eb0c 100644 > --- a/drivers/usb/core/hcd.c > +++ b/drivers/usb/core/hcd.c > @@ -11,7 +11,6 @@ > #include <linux/bcd.h> > #include <linux/module.h> > -#include <linux/version.h> > #include <linux/kernel.h> > #include <linux/sched/task_stack.h> > #include <linux/slab.h> > Your tool is VERY broken. Please stop sending patches that you obviously do not even test before submitting: https://lore.kernel.org/r/1614733752-56541-1-git-send-email-tiantao6@xxxxxxxxxxxxx It's a sure way to make maintainers very grumpy. greg k-h
