RE: FW: FW: [PATCH 002/002] USB: serial: sierra driver autosuspend support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 5 Aug 2009, Rory Filer wrote:

> There remain two quibbles to using the .../power/level (or the other) 
> attribute; first, the current setting of "ON" may not always remain that 
> way. There have been precedents in the past for things changing unexpectedly 
> from one release of kernel to the next (e.g. system tick interval). So I 
> wouldn't say it's impossible for someone to get the bright idea to change 
> ON to AUTO or something else in future.

The initial setting won't change.  There are too many buggy devices out 
there for that to happen.  However it's always possible that some user 
program might foolishly change the value from "on" to "auto" -- in 
fact, there are programs out there which do this.

> Second, the solution for changing
> it to AUTO when it actually needs to be changed to AUTO needs to differ 
> depending upon what services are installed in a particular user's system.

This means the solution shouldn't be part of the kernel.  It should run 
in userspace, where it can change along with the set of installed 
services.


> > Your module parameter isn't such a good solution because it would _not_
> > work the same way across all kernels.  It wouldn't work at all for
> > kernels before 2.6.31, then it would work for some indefinite number of
> > kernels to follow, and then for even later kernels it would once again
> > stop working.
> 
> Actually, it does work all the way back to 2.6.23 because we've tested it,

I don't understand.  How can you possibly test the module parameter
under 2.6.23?  It didn't exist in that kernel.

Maybe you meant that if you _change_ 2.6.23 by adding the module 
parameter, then it will work.  That's quite a different matter.

> so I'm not sure what you are getting at here. In any case, we've decided 
> to get rid of it for now and will use the existing power attributes, so it's
> a moot point.

Okay, good.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux