On Tue, Mar 23, 2021 at 4:36 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > During conversion to use GPIO descriptors the device pointer, > which is applied to devm_gpiod_get(), is not yet initialized. > > Move initialization in the ->probe() in order to have it set before use. > > Fixes: e20849a8c883 ("usb: gadget: pch_udc: Convert to use GPIO descriptors") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Ooops sorry. Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij