Re: [PATCH -next] usb: typec: tcpci_maxim: Make symbol 'max_tcpci_tcpci_write_table' static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 24, 2021 at 02:42:53PM +0000, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> 
> The sparse tool complains as follows:
> 
> drivers/usb/typec/tcpm/tcpci_maxim.c:55:34: warning:
>  symbol 'max_tcpci_tcpci_write_table' was not declared. Should it be static?
> 
> This symbol is not used outside of tcpci_maxim.c, so this
> commit marks it static.
> 
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/usb/typec/tcpm/tcpci_maxim.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
> index 041a1c393594..df2505570f07 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
> @@ -52,7 +52,7 @@ static const struct regmap_range max_tcpci_tcpci_range[] = {
>  	regmap_reg_range(0x00, 0x95)
>  };
>  
> -const struct regmap_access_table max_tcpci_tcpci_write_table = {
> +static const struct regmap_access_table max_tcpci_tcpci_write_table = {
>  	.yes_ranges = max_tcpci_tcpci_range,
>  	.n_yes_ranges = ARRAY_SIZE(max_tcpci_tcpci_range),
>  };
> 



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux