> -----Original Message----- > From: Alan Stern [mailto:stern@xxxxxxxxxxxxxxxxxxx] > Sent: Tuesday, July 21, 2009 7:33 AM > To: Oliver Neukum > > On Tue, 21 Jul 2009, Oliver Neukum wrote: > > > > > I am afraid we cannot simply ignore this. We have devices which may > > crash in a system wide suspension. They need to be marked as needing > > RESET_RESUME. > > It's not clear that the quirk is necessary. If a device crashes badly > enough during suspend (i.e., if it can no longer respond to a > Get-Device-Status request) then usbcore will detect a problem when it > tries to resume the device. > > Otherwise, yes, sierra modem devices can be marked with this quirk. > The sierra driver doesn't need to be changed though -- only quirks.c. I have a few questions on this quirks.c file and its use: 1) It looks like quirks.c can be compiled separately as a kernel module and then loaded at runtime. This would be very handy in the event it becomes necessary some day to override one of our devices being in this list. 2) If the answer to question 1 is NO, you can't treat quirks.c as a kernel module, then is there another way to override an entry without having to rebuild the whole kernel? 3) Just so I'm clear on this, if a device is present in the quirks list, it doesn't stop the kernel from suspending it, it just ensures that a device will be disconnected and re-enumerated as part of the resume, correct? 4) In our testing we've only seen a small number of our modems crash when they are resumed. Once they are up again they appear to be re-enumerated properly and we can access the various ttyUSBx's again. reading through the quirks.c file in drivers/usb/core I note there aren't very many devices listed in there. My question is, what does it take for a device to become eligible for inclusion in this file/driver? Regards Rory Filer -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
