Hello.
Subbrathnam, Swaminathan wrote:
Is there any updated patches available after the below patch?
Not yet. Will refresh the patcn ASAP.
When I tried to apply the patch I get patch malformed errors as below
"patching file drivers/usb/musb/Kconfig
patch: **** malformed patch at line 44: Index: linux-davinci/drivers/usb/musb/Makefile"
I tried to apply the patch saved by my mailer and nothing alike was
reported.
When I run the checkpatch against the patch I see errors as below
ERROR: patch seems to be corrupt (line wrapped?)
#44: FILE: drivers/usb/musb/Kconfig:174:
Index: linux-davinci/drivers/usb/musb/Makefile
Your mailer probably corrupted the patch when saving...
ERROR: open brace '{' following function declarations go on the next line
#196: FILE: drivers/usb/musb/cppi41_dma.c:128:
+static void print_pd_list(struct usb_pkt_desc *pd_pool_head) {
ERROR: open brace '{' following function declarations go on the next line
#211: FILE: drivers/usb/musb/cppi41_dma.c:143:
+static struct usb_pkt_desc *usb_get_free_pd(struct cppi41 *cppi) {
ERROR: open brace '{' following function declarations go on the next line
#376: FILE: drivers/usb/musb/cppi41_dma.c:308:
+static int cppi41_controller_stop(struct dma_controller *controller) {
ERROR: open brace '{' following function declarations go on the next line
#524: FILE: drivers/usb/musb/cppi41_dma.c:456:
+static void cppi41_channel_release(struct dma_channel *channel) {
ERROR: open brace '{' following function declarations go on the next line
#591: FILE: drivers/usb/musb/cppi41_dma.c:523:
+static unsigned cppi41_next_tx_segment(struct cppi41_channel *tx_ch) {
ERROR: open brace '{' following function declarations go on the next line
#787: FILE: drivers/usb/musb/cppi41_dma.c:719:
+static unsigned cppi41_next_rx_segment(struct cppi41_channel *rx_ch) {
ERROR: open brace '{' following function declarations go on the next line
#959: FILE: drivers/usb/musb/cppi41_dma.c:891:
+static void usb_tx_ch_teardown(struct cppi41_channel *tx_ch) {
ERROR: open brace '{' following function declarations go on the next line
#985: FILE: drivers/usb/musb/cppi41_dma.c:917:
+static void usb_rx_ch_teardown(struct cppi41_channel *rx_ch) {
ERROR: open brace '{' following function declarations go on the next line
#1045: FILE: drivers/usb/musb/cppi41_dma.c:977:
+static int cppi41_channel_abort(struct dma_channel *channel) {
ERROR: open brace '{' following function declarations go on the next line
#1206: FILE: drivers/usb/musb/cppi41_dma.c:1138:
+void dma_controller_destroy(struct dma_controller *controller) {
ERROR: open brace '{' following function declarations go on the next line
#1215: FILE: drivers/usb/musb/cppi41_dma.c:1147:
+static void usb_process_tx_queue(struct cppi41 *cppi, unsigned index) {
ERROR: open brace '{' following function declarations go on the next line
#1264: FILE: drivers/usb/musb/cppi41_dma.c:1196:
+static void usb_process_rx_queue(struct cppi41 *cppi, unsigned index) {
If you look at the patch, you'll see nothing alike in it, all such
braces are on the seperate lines. Something was surely corrupted on your side.
ERROR: Missing Signed-off-by: line(s)
The only error I got when running checkpatch.pl on the patch that I
saved from the original mail was about the missing signoff.
total: 14 errors, 0 warnings, 1446 lines checked
/user/a0876246/cpppi41patch.txt has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
I would like to know when and how the cppi41 related patches will be taken up for review/discussion as I do not see these patches queued up yet for merge.
I'm going to repost them soon...
Regards
swami
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
