Re: [PATCH] usb: gadget: udc: amd5536udc_pci fix crash if dma is used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 13, 2021 at 02:20:32PM -0500, Tong Zhang wrote:
> init_dma_pools() calls dma_pool_create(...dev->dev) to create dma pool.
> however, dev->dev is actually set after calling init_dma_pools(), which
> effectively makes dma_pool_create(..NULL) and cause crash.
> To fix this issue, init dma only after dev->dev is set.
> 
> [    1.317993] RIP: 0010:dma_pool_create+0x83/0x290
> [    1.323257] Call Trace:
> [    1.323390]  ? pci_write_config_word+0x27/0x30
> [    1.323626]  init_dma_pools+0x41/0x1a0 [snps_udc_core]
> [    1.323899]  udc_pci_probe+0x202/0x2b1 [amd5536udc_pci]
> 
> Signed-off-by: Tong Zhang <ztong0001@xxxxxxxxx>

What commit caused this problem?

Can you resend this with a "Fixes:" tag added showing that?

thanks,

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux