On Sat, Mar 13, 2021 at 11:14:51AM +0900, Klemen Košir wrote: > On Thu, Mar 11, 2021 at 05:38:32PM +0100, Johan Hovold wrote: > > On Thu, Mar 11, 2021 at 10:14:35PM +0900, Klemen Košir wrote: > > > This patch fixes some spelling mistakes and improves wording in some > > > comments. It also renames one variable to unify naming with others. > > > > It sounds like you're trying to do too many things at once, and I'm not > > sure this kind of changes are worth it unless also doing some "real" > > changes to the code in question. > > If you want you can submit a v2 which fixes the two obvious > > spelling/grammar mistakes and the Hz capitalisation that you found. > > > > But I strongly recommend you stop submitting patches like this. We have > > a ton of real issues that needs tending too if you're looking for > > something to work on. > > Thank you for the feedback. I wasn't aware of the meaning of "iff". > I thought this patch might have some value. I will put in more effort > in the future. > > Apologies for the inconvenience. No worries. It's just that some types of clean up patches tend to mostly add noise and make things like git blame harder to use. The general rule is to not send pure cleanup patches for things outside of drivers/staging/ unless also doing other changes to the code in question. Fixing spelling mistakes and grammar may be worth it in itself if it fixes ambiguity or improves readability generally. And then it's good to do as you did here and fix it all in one go (e.g. per driver). But otherwise comments (or style generally) don't have to be perfect. Johan
