Re: [PATCH 2/2] CDC-ACM: downgrade message to debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Den tor. 11. mar. 2021 kl. 14.01 skrev Oliver Neukum <oneukum@xxxxxxxx>:
>
> This failure is so common that logging an error here amounts
> to spamming log files.
>
> Signed-off-by: Oliver Neukum <oneukum@xxxxxxxx>

Reviewed-by: Bruno Thomsen <bruno.thomsen@xxxxxxxxx>

I can confirm that this error message is very common on
embedded Linux systems.

/Bruno

> ---
>  drivers/usb/class/cdc-acm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index d684cf94b1c0..fd2fce072985 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -659,7 +659,8 @@ static void acm_port_dtr_rts(struct tty_port *port, int raise)
>
>         res = acm_set_control(acm, val);
>         if (res && (acm->ctrl_caps & USB_CDC_CAP_LINE))
> -               dev_err(&acm->control->dev, "failed to set dtr/rts\n");
> +               /* This is broken in too many devices to spam the logs */
> +               dev_dbg(&acm->control->dev, "failed to set dtr/rts\n");
>  }
>
>  static int acm_port_activate(struct tty_port *port, struct tty_struct *tty)
> --
> 2.26.2
>



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux